Restore ServeProto::Command::ImportPaths#14263
Merged
Ericson2314 merged 1 commit intomasterfrom Oct 15, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
xokdvium
force-pushed
the
hydra-import-paths
branch
from
376114b to
c3bb50e
Compare
github-actions
bot
added
new-cli
xokdvium
changed the title
Ericson2314
force-pushed
the
hydra-import-paths
branch
from
c3bb50e to
0038b0f
Compare
Ericson2314
changed the title
ServeProto::Command::ImportPaths
Ericson2314
force-pushed
the
hydra-import-paths
branch
3 times, most recently
from
e268146 to
b703aa1
Compare
This partially reverts commit 5e46df9, partially reversing changes made to 8c789db. We do this because Hydra, while using the newer version of the protocol, still uses this command, even though Nix (as a client) doesn't use it. On that basis, we don't want to remove it (or consider it only part of the older versions of the protocol) until Hydra no longer uses the Legacy SSH Protocol.
Ericson2314
force-pushed
the
hydra-import-paths
branch
from
b703aa1 to
0deb492
Compare
Ericson2314
added
the
backport 2.32-maintenance
Ericson2314
approved these changes
Oct 15, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
I have tested a local build of Hydra with this backported to Nix 2.32. So I know that this builds, and I am pretty confident that it works because Hydra's tests should exercise the code.
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This partially reverts commit 5e46df9, partially reversing changes made to 8c789db.
Context
We do this because Hydra, while using the newer version of the protocol, still uses this command, even though Nix (as a client) doesn't use it. On that basis, we don't want to remove it (or consider it only part of the older versions of the protocol) until Hydra no longer uses the Legacy SSH Protocol.
This is still used by hydra NixOS/hydra#1531.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.