test(nixos): add comprehensive curl-based S3 VM tests#14223
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Oct 14, 2025
Merged
test(nixos): add comprehensive curl-based S3 VM tests#14223Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
lovesegfault
force-pushed
the
curl-based-s3-tests
branch
3 times, most recently
from
cefee07 to
9bb974f
Compare
Add `curl-s3-binary-cache-store.nix` with comprehensive test coverage for the curl-based S3 implementation. Depends-On: NixOS#14206, NixOS#14222
lovesegfault
force-pushed
the
curl-based-s3-tests
branch
from
9bb974f to
d18f959
Compare
xokdvium
reviewed
Oct 14, 2025
Comment on lines
+204
to
+205
| curl-s3-binary-cache-store = runNixOSTest ./curl-s3-binary-cache-store.nix; | ||
|
|
Contributor
There was a problem hiding this comment.
This won't pass on hydra though, right?
Contributor
There was a problem hiding this comment.
Seems fine for now considering that the old implementation is not long for this world
xokdvium
approved these changes
Oct 14, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
curl-s3-binary-cache-store.nixwith comprehensive test coveragefor the curl-based S3 implementation.
Context
Part of #13752
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.