refactor(libstore): expose DummyStoreImpl in header for testability#14221
Closed
lovesegfault wants to merge 1 commit intoNixOS:masterfrom
Closed
refactor(libstore): expose DummyStoreImpl in header for testability#14221lovesegfault wants to merge 1 commit intoNixOS:masterfrom
lovesegfault wants to merge 1 commit intoNixOS:masterfrom
Conversation
Move DummyStoreImpl from dummy-store.cc to dummy-store-impl.hh to allow tests to inherit from it and use gmock for method mocking.
github-actions
bot
added
the
store
Member
|
See what I wrote in #14219 (comment) dummy store is already a mock store in some sense. I don't really get why we need this or gmock, but perhaps I'm missing something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Move DummyStoreImpl from dummy-store.cc to dummy-store-impl.hh to allow
tests to inherit from it and use gmock for method mocking.
Context
Needed for: #14219
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.