feat(libstore): make cycle errors more verbose#14218

Open

lovesegfault wants to merge 20 commits intoNixOS:masterfrom

lovesegfault:better-cycle-errors

Commits on Oct 25, 2025

feat(libstore): make cycle errors more verbose

lovesegfault
and
milahu
committed
refactor(libstore/find-cycles): use RefScanSink
lovesegfault
committed
perf(libstore/find-cycles): avoid copying StringSet on every chunk
lovesegfault
committed
refactor(libstore/find-cycles): remove unused hashPathMap parameter
lovesegfault
committed
refactor(libstore/find-cycles): make edges member private
lovesegfault
committed
fix(libstore/find-cycles): use readFull for robust file reading
lovesegfault
committed
refactor(libstore/find-cycles): remove unused refLength constant
lovesegfault
committed
style(libstore/find-cycles): use initializer list for edge construction
lovesegfault
committed
fix(libstore/find-cycles): add second pass to merge multiedges
lovesegfault
committed
refactor(libstore/find-cycles): use portable std::filesystem and readFile APIs
lovesegfault
committed
style(libstore/find-cycles): modernize type aliases (typedef → using)
lovesegfault
committed
refactor(libstore/find-cycles): add explicit include for caseHackSuffix
lovesegfault
committed
refactor(libstore/find-cycles): use std::filesystem::path operator/
lovesegfault
committed
refactor(libstore/find-cycles): rename scanForCycleEdges2 → walkAndScanPath
lovesegfault
committed
refactor(libstore/find-cycles): use std::filesystem::path parameter
lovesegfault
committed
refactor(libstore/find-cycles): conditionally include archive.hh on macOS only
lovesegfault
committed
fix(libstore/find-cycles): install header in public include directory
lovesegfault
committed
test(libstore): add parametrized tests for transformEdgesToMultiedges
lovesegfault
committed
perf(libstore/find-cycles): optimize transformEdgesToMultiedges to O(n)
lovesegfault
committed
refactor(libstore/find-cycles): use SourceAccessor for filesystem access
lovesegfault
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(libstore): make cycle errors more verbose#14218

feat(libstore): make cycle errors more verbose#14218
lovesegfault wants to merge 20 commits intoNixOS:masterfrom
lovesegfault:better-cycle-errors

Commits on Oct 25, 2025

feat(libstore): make cycle errors more verbose

refactor(libstore/find-cycles): use RefScanSink

perf(libstore/find-cycles): avoid copying StringSet on every chunk

refactor(libstore/find-cycles): remove unused hashPathMap parameter

refactor(libstore/find-cycles): make edges member private

fix(libstore/find-cycles): use readFull for robust file reading

refactor(libstore/find-cycles): remove unused refLength constant

style(libstore/find-cycles): use initializer list for edge construction

fix(libstore/find-cycles): add second pass to merge multiedges

refactor(libstore/find-cycles): use portable std::filesystem and readFile APIs

style(libstore/find-cycles): modernize type aliases (typedef → using)

refactor(libstore/find-cycles): add explicit include for caseHackSuffix

refactor(libstore/find-cycles): use std::filesystem::path operator/

refactor(libstore/find-cycles): rename scanForCycleEdges2 → walkAndScanPath

refactor(libstore/find-cycles): use std::filesystem::path parameter

refactor(libstore/find-cycles): conditionally include archive.hh on macOS only

fix(libstore/find-cycles): install header in public include directory

test(libstore): add parametrized tests for transformEdgesToMultiedges

perf(libstore/find-cycles): optimize transformEdgesToMultiedges to O(n)

refactor(libstore/find-cycles): use SourceAccessor for filesystem access