feat(libstore): add curl-based S3 store implementation#14198
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Oct 10, 2025
Merged
feat(libstore): add curl-based S3 store implementation#14198xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
Ericson2314
reviewed
Oct 9, 2025
Ericson2314
reviewed
Oct 9, 2025
lovesegfault
force-pushed
the
curl-based-s3-pieces
branch
4 times, most recently
from
1209c1b to
e0910b1
Compare
Ericson2314
approved these changes
Oct 9, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
It looks good from me, but I would appreciate @xokdvium as another set of eyes
Ericson2314
reviewed
Oct 9, 2025
xokdvium
reviewed
Oct 9, 2025
xokdvium
requested changes
Oct 9, 2025
xokdvium
reviewed
Oct 9, 2025
xokdvium
reviewed
Oct 9, 2025
xokdvium
reviewed
Oct 9, 2025
xokdvium
reviewed
Oct 9, 2025
xokdvium
reviewed
Oct 9, 2025
lovesegfault
force-pushed
the
curl-based-s3-pieces
branch
3 times, most recently
from
c8d3c41 to
7701bb3
Compare
Add a new S3BinaryCacheStore implementation that inherits from HttpBinaryCacheStore. The implementation is activated with NIX_WITH_CURL_S3, keeping the existing NIX_WITH_S3_SUPPORT (AWS SDK) implementation unchanged.
lovesegfault
force-pushed
the
curl-based-s3-pieces
branch
from
7701bb3 to
0855b71
Compare
xokdvium
approved these changes
Oct 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a new
S3BinaryCacheStoreimplementation that inherits fromHttpBinaryCacheStore.The implementation is activated with
NIX_WITH_CURL_S3, keeping theexisting
NIX_WITH_S3_SUPPORT(AWS SDK) implementation unchanged.Context
Carve out of #13752
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.