feat(libstore/filetransfer): add username/password authentication support#14190
Merged
github-merge-queue[bot] merged 1 commit intoNixOS:masterfrom Oct 8, 2025
Merged
Conversation
xokdvium
reviewed
Oct 8, 2025
lovesegfault
force-pushed
the
filetransfer-username-auth
branch
3 times, most recently
from
1449ecb to
a357722
Compare
…port Add a `UsernameAuth` struct and optional `usernameAuth` field to `FileTransferRequest` to support programmatic username/password authentication. This uses curl's `CURLOPT_USERNAME`/`CURLOPT_PASSWORD` options, which works with multiple protocols (HTTP, FTP, etc.) and is not specific to any particular authentication scheme. The primary motivation is to enable S3 authentication refactoring where AWS credentials (access key ID and secret access key) can be passed through this general-purpose mechanism, reducing the amount of S3-specific code behind `#if NIX_WITH_CURL_S3` guards.
lovesegfault
force-pushed
the
filetransfer-username-auth
branch
from
a357722 to
3c1e2e5
Compare
Ericson2314
approved these changes
Oct 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a
UsernameAuthstruct and optionalusernameAuthfield toFileTransferRequestto support programmatic username/passwordauthentication.
This uses curl's
CURLOPT_USERNAME/CURLOPT_PASSWORDoptions, whichworks with multiple protocols (HTTP, FTP, etc.) and is not specific to
any particular authentication scheme.
The primary motivation is to enable S3 authentication refactoring where
AWS credentials (access key ID and secret access key) can be passed
through this general-purpose mechanism, reducing the amount of
S3-specific code behind
#if NIX_WITH_CURL_S3guards.Context
This is a carve-out #14170 which is a carve-out of #13752
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.