feat(libstore/http-binary-cache-store): narinfo/ls/log compression#14120
Merged
Mic92 merged 3 commits intoNixOS:masterfrom Sep 30, 2025
Merged
feat(libstore/http-binary-cache-store): narinfo/ls/log compression#14120Mic92 merged 3 commits intoNixOS:masterfrom
Mic92 merged 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
http-binary-cache-compression
branch
from
1b7b0d8 to
d4beddb
Compare
xokdvium
reviewed
Sep 29, 2025
xokdvium
reviewed
Sep 29, 2025
lovesegfault
force-pushed
the
http-binary-cache-compression
branch
from
d4beddb to
689fa81
Compare
Member
|
@brianmcgee this might be relevant to know for your binary cache proxy. |
Contributor
|
@Mic92 thanks for the heads up, this will have an impact. I'm currently compressing logs on write through as that's what the s3 endpoint does but not the http. |
Member
|
I extended a test that shows how substitution with nginx could be used with this. |
Mic92
force-pushed
the
http-binary-cache-compression
branch
from
0f5138f to
3fcd330
Compare
Mic92
approved these changes
Sep 30, 2025
Member
|
OK cool, doing this separately is actually more useful than I thought, even though I proposed it. :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#13752 (comment)
Context
I don't know how to write tests for this without the s3 changes in place.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.