test(libstore): additional ParsedS3Url tests#14026
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Sep 19, 2025
Merged
Conversation
Ericson2314
reviewed
Sep 19, 2025
lovesegfault
force-pushed
the
s3-url-tests
branch
from
a89ec98 to
85e0214
Compare
Ericson2314
approved these changes
Sep 19, 2025
xokdvium
reviewed
Sep 19, 2025
xokdvium
reviewed
Sep 19, 2025
xokdvium
requested changes
Sep 19, 2025
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Can we stop with AI slop tests?
Member
|
@xokdvium I think these were actually the original tests that then got improved into the now upstreamed tests when At least that is my understanding of events. |
Member
|
If the bottom added section is removed, it is good right @xokdvium? The invalid URL tests above are not duplicative, right? |
Contributor
Yeah, that is good. |
lovesegfault
force-pushed
the
s3-url-tests
branch
from
85e0214 to
a1e0252
Compare
xokdvium
reviewed
Sep 19, 2025
Extracted from the work in NixOS#13752
lovesegfault
force-pushed
the
s3-url-tests
branch
from
a1e0252 to
b63d9fb
Compare
xokdvium
approved these changes
Sep 19, 2025
Member
Author
|
@xokdvium can you re-enable auto-merge, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Extracted from the work in #13752
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.