Skip to content

nix develop: Version the JSON #13947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edolstra wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nix develop: Version the JSON #13947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/nix/get-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ __functions="$(declare -F)"

__dumpEnv() {
printf '{\n'
printf ' "version": 1,\n'
Copy link
Member

@Mic92 Mic92 Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not opposing to have this, but have you have a more concrete motivation for this change i.e. can you elaborate how "could even be pushed to binary caches" would be used? Afaik mkShell is buildable and can be already pushed to a binary cache. You removed the the version 1 from flakes again for the reason that a "v2" would be the first explicit version and before everything is "v1".

Copy link
Member

@Ericson2314 Ericson2314 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think some docs would be good. For example, the JSON schema I've been doing would be good for this. I think it is OK if we ret-con version 1 to either have no version, or have version = 1, however. And then version 2 can wait for a more "meaningful" breaking change.


printf ' "bashFunctions": {\n'
local __first=1
Expand Down
Loading