JSON impl and Schema for `DummyStore` by Ericson2314 · Pull Request #13942 · NixOS/nix

Ericson2314 · 2025-09-08T22:36:31Z

Motivation

See issue.

Context

This is the "keystone" that puts most of the other store-layer JSON formats together.

Progress on #13570

Depends on #13980
Depends on #14226

I talked to @edolstra about this at NixCon, briefly.

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Ericson2314 · 2025-09-10T20:18:31Z

I discussed this with @edolstra a bit at the meeting

nix path-info is widely used, needs proper migration/compat story, even though technically experimental
- Solution: This PR no longer changes that command at all. I makes a new JSON instance "side by side"
~~nix derivation is less-often used, can probably just change it (it is experimental new CLI, of course)~~
- We agreed just to do this. It was done in an earlier PR.
Coordinate hash format with https://github.com/DeterminateSystems/nix-src/blob/3ccbe8465909bc37e222c8a2c2e047142252a083/src/libutil/hash.cc#L473-L479
- This one is slightly different, but I think it is better.

Misc prep changes for #13942

dpulls · 2025-09-17T21:31:44Z

🎉 All dependencies have been resolved !

dpulls · 2025-10-15T22:10:00Z

🎉 All dependencies have been resolved !

Ericson2314 · 2025-10-15T22:42:12Z

src/libstore-tests/data/dummy-store/one-flat-file.json

+      }
+    }
+  },
+  "store-dir": "/nix/store"


Should we but camel case in the JSON guide (and change this)?

Also think this should go with in a config object.

That'd be good

src/libutil-test-support/include/nix/util/tests/json-characterization.hh

Radvendii

This looks good to me, but I am not very familiar with any of the pieces involved (json serialization/deserialization in C++, this json schema system, the testing framework, etc.) So I'm mostly only able to take things at face value.

src/libutil-test-support/include/nix/util/tests/json-characterization.hh

Also skip a trailing semicolon inside a macro so the caller can use it instead, which is generally nicer to the formatter.

Otherwise the equality instance we need to add will be messed up.

Will need it for tests.

This is the "keystone" that puts most of the other store-layer JSON formats together. Also, add some documentation for JSON testing.

Ericson2314 force-pushed the json-no-store-dir branch 2 times, most recently from 3208245 to 2704e1a Compare September 10, 2025 19:48

Ericson2314 force-pushed the json-no-store-dir branch from 2704e1a to 8b413c1 Compare September 11, 2025 21:49

github-actions bot added new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store fetching Networking with the outside (non-Nix) world, input locking labels Sep 11, 2025

Ericson2314 force-pushed the json-no-store-dir branch from 8b413c1 to 05a4cf9 Compare September 11, 2025 22:07

github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Sep 11, 2025

Ericson2314 force-pushed the json-no-store-dir branch from 05a4cf9 to 1d1b475 Compare September 12, 2025 22:04

Ericson2314 mentioned this pull request Sep 12, 2025

Misc prep changes for #13942 #13975

Merged

Ericson2314 added a commit that referenced this pull request Sep 13, 2025

Merge pull request #13975 from obsidiansystems/prep-json-0

1710fd0

Misc prep changes for #13942

Ericson2314 force-pushed the json-no-store-dir branch from 1d1b475 to fdf7dfd Compare September 13, 2025 13:39

github-actions bot added the documentation label Sep 13, 2025

Ericson2314 mentioned this pull request Sep 13, 2025

ValidPathInfo, NarInfo, turn funky constructor into static method #13982

Merged

Ericson2314 force-pushed the json-no-store-dir branch from fdf7dfd to 3f60123 Compare September 28, 2025 06:54

github-actions bot added the c api Nix as a C library with a stable interface label Sep 28, 2025

Ericson2314 force-pushed the json-no-store-dir branch from 3f60123 to fdae31a Compare October 1, 2025 05:37

Ericson2314 marked this pull request as ready for review October 1, 2025 20:10

Ericson2314 requested a review from edolstra as a code owner October 1, 2025 20:10

Ericson2314 force-pushed the json-no-store-dir branch 2 times, most recently from d046757 to aa7033c Compare October 1, 2025 21:10

Ericson2314 force-pushed the json-no-store-dir branch from aa7033c to 57b1332 Compare October 11, 2025 22:07

Ericson2314 mentioned this pull request Oct 12, 2025

libstore: Avoid copying derivations to the store if they are already valid #14219

Merged

Ericson2314 force-pushed the json-no-store-dir branch from 57b1332 to 0836ead Compare October 12, 2025 14:33

Ericson2314 mentioned this pull request Oct 14, 2025

Make Dummy store store derivations separately #14246

Merged

Ericson2314 force-pushed the json-no-store-dir branch from 0836ead to edd081c Compare October 15, 2025 22:40

Ericson2314 commented Oct 15, 2025

View reviewed changes

Ericson2314 force-pushed the json-no-store-dir branch from 9c0df68 to c893454 Compare November 6, 2025 18:56

Ericson2314 mentioned this pull request Nov 10, 2025

Make OutputsSpec::All JSON be "*" not ["*"] #14528

Draft

Ericson2314 mentioned this pull request Nov 18, 2025

Remove dependent realisations #14247

Merged

Ericson2314 force-pushed the json-no-store-dir branch 2 times, most recently from 892c736 to 8ffc6b5 Compare November 21, 2025 04:38

Ericson2314 changed the title ~~JSON impls without store dir~~ JSON impl and Schema for DummyStore Nov 21, 2025

Ericson2314 mentioned this pull request Nov 21, 2025

Store dirs in store paths in JSON, JSON Schemas, and other cleanup #13570

Open

32 tasks

Ericson2314 commented Nov 24, 2025

View reviewed changes

src/libutil-test-support/include/nix/util/tests/json-characterization.hh Outdated Show resolved Hide resolved

Radvendii reviewed Nov 24, 2025

View reviewed changes

src/libutil-test-support/include/nix/util/tests/json-characterization.hh Outdated Show resolved Hide resolved

Ericson2314 force-pushed the json-no-store-dir branch 2 times, most recently from 8e3d652 to fee3266 Compare November 24, 2025 19:17

roberth approved these changes Nov 24, 2025

View reviewed changes

Ericson2314 force-pushed the json-no-store-dir branch 3 times, most recently from 66957e2 to 31f1edf Compare November 24, 2025 20:30

Mic92 approved these changes Nov 24, 2025

View reviewed changes

Mic92 enabled auto-merge November 24, 2025 20:41

Mic92 added this pull request to the merge queue Nov 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 24, 2025

Ericson2314 added 5 commits November 24, 2025 17:03

Document the JSON Schema testing a bit

f198e9a

Add some infrastructure changes for better JSON ref<T> impls

f78e88c

Also skip a trailing semicolon inside a macro so the caller can use it instead, which is generally nicer to the formatter.

DummyStore build trace holds UnkeyedRealisation by value

b0c016a

Otherwise the equality instance we need to add will be messed up.

Add DummyStore::operator==

622a5cd

Will need it for tests.

JSON impl and Schema for DummyStore

0275b64

This is the "keystone" that puts most of the other store-layer JSON formats together. Also, add some documentation for JSON testing.

Ericson2314 force-pushed the json-no-store-dir branch from 31f1edf to 0275b64 Compare November 24, 2025 22:06

Ericson2314 enabled auto-merge November 24, 2025 22:19

Ericson2314 added this pull request to the merge queue Nov 24, 2025

Merged via the queue into master with commit 4f4da90 Nov 24, 2025
20 checks passed

Ericson2314 deleted the json-no-store-dir branch November 24, 2025 23:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

JSON impl and Schema for `DummyStore`#13942

JSON impl and Schema for `DummyStore`#13942
Ericson2314 merged 5 commits intomasterfrom
json-no-store-dir

Ericson2314 commented Sep 8, 2025 •

edited

Loading

Uh oh!

Ericson2314 commented Sep 10, 2025 •

edited

Loading

Uh oh!

dpulls bot commented Sep 17, 2025

Uh oh!

dpulls bot commented Oct 15, 2025

Uh oh!

Ericson2314 Oct 15, 2025

Uh oh!

roberth Oct 15, 2025

Uh oh!

Uh oh!

Radvendii left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Ericson2314 commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Context

Uh oh!

Ericson2314 commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dpulls bot commented Sep 17, 2025

Uh oh!

dpulls bot commented Oct 15, 2025

Uh oh!

Ericson2314 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

roberth Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Radvendii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ericson2314 commented Sep 8, 2025 •

edited

Loading

Ericson2314 commented Sep 10, 2025 •

edited

Loading