Reapply "Merge pull request #13741 from xokdvium/toml-timestamps"#13883
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Sep 1, 2025
Merged
Reapply "Merge pull request #13741 from xokdvium/toml-timestamps"#13883Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
This reverts commit 75740fb.
This adds regression tests for fromTOML overflow/underflow behavior. Previous versions of toml11 used to saturate, but this was never an intended behavior (and Snix/Nix 2.3/toml11 >= 4.0 validate this). (cherry picked from Lix [1,2]) [1]: https://git.lix.systems/lix-project/lix/commit/7ee442079dfbae4fe2d2fbb91a7226b87251cd65 [2]: https://git.lix.systems/lix-project/lix/commit/4de09b6b5493db4bd7f6348255a1fdcb38b9ed2f
github-actions
bot
added
the
with-tests
Mic92
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This reverts commit 75740fb. The offending tests have been fixed in nixpkgs (NixOS/nixpkgs#433710). Backports of the original PR (#13741) have been merged since. This cherry-picks a test for the error (thanks @emilazy).
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.