Skip to content

Comments

feat(libstore/s3): add toHttpsUrl#13823

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
lovesegfault:extract-s3ToHttpsURL
Aug 25, 2025
Merged

feat(libstore/s3): add toHttpsUrl#13823
Ericson2314 merged 1 commit intoNixOS:masterfrom
lovesegfault:extract-s3ToHttpsURL

Conversation

@lovesegfault
Copy link
Member

Motivation

This is extracted from the work in #13752

c.f. #13752 (comment)

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new toHttpsUrl() method to the ParsedS3URL class that converts S3 URLs to HTTPS URLs for use with curl's AWS SigV4 authentication. This enhancement supports better integration with HTTP-based S3 operations.

  • Adds toHttpsUrl() method to convert S3 URLs to HTTPS format
  • Handles various endpoint configurations including custom endpoints and AWS regions
  • Includes comprehensive test coverage for different S3 URL conversion scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/libstore/include/nix/store/s3.hh Adds method declaration and documentation for toHttpsUrl()
src/libstore/s3.cc Implements the toHttpsUrl() method with endpoint handling logic
src/libstore-tests/s3.cc Adds parameterized tests covering various S3 URL conversion scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ericson2314 Ericson2314 self-assigned this Aug 25, 2025
@lovesegfault lovesegfault force-pushed the extract-s3ToHttpsURL branch 3 times, most recently from 67f5354 to 135840b Compare August 25, 2025 18:35
This is extracted from the work in NixOS#13752
@Ericson2314 Ericson2314 enabled auto-merge August 25, 2025 18:50
@Ericson2314 Ericson2314 merged commit 024d395 into NixOS:master Aug 25, 2025
12 checks passed
@lovesegfault lovesegfault deleted the extract-s3ToHttpsURL branch August 25, 2025 20:01
@edolstra edolstra mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants