feat(libstore/s3): add toHttpsUrl#13823
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Aug 25, 2025
Merged
Conversation
c0eb873 to
ca519b4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new toHttpsUrl() method to the ParsedS3URL class that converts S3 URLs to HTTPS URLs for use with curl's AWS SigV4 authentication. This enhancement supports better integration with HTTP-based S3 operations.
- Adds
toHttpsUrl()method to convert S3 URLs to HTTPS format - Handles various endpoint configurations including custom endpoints and AWS regions
- Includes comprehensive test coverage for different S3 URL conversion scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/libstore/include/nix/store/s3.hh |
Adds method declaration and documentation for toHttpsUrl() |
src/libstore/s3.cc |
Implements the toHttpsUrl() method with endpoint handling logic |
src/libstore-tests/s3.cc |
Adds parameterized tests covering various S3 URL conversion scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
xokdvium
reviewed
Aug 25, 2025
Ericson2314
reviewed
Aug 25, 2025
Ericson2314
reviewed
Aug 25, 2025
ca519b4 to
94edec9
Compare
Ericson2314
reviewed
Aug 25, 2025
Ericson2314
reviewed
Aug 25, 2025
Ericson2314
reviewed
Aug 25, 2025
Ericson2314
reviewed
Aug 25, 2025
67f5354 to
135840b
Compare
Ericson2314
reviewed
Aug 25, 2025
Ericson2314
reviewed
Aug 25, 2025
135840b to
663c0d5
Compare
This is extracted from the work in NixOS#13752
663c0d5 to
5985d67
Compare
Ericson2314
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is extracted from the work in #13752
c.f. #13752 (comment)
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.