Merged
Conversation
Ericson2314
reviewed
Aug 18, 2025
| nix.package = lib.mkForce ( | ||
| pkgs.nixVersions.nix_2_3.overrideAttrs (o: { | ||
| meta = o.meta // { | ||
| knownVulnerabilities = [ ]; |
Member
There was a problem hiding this comment.
I would add the explanation to the code, for someone to read before they freak out and maybe don't bother with git blame.
25.05 has it marked as insecure, but we don't care about it for testing purposes.
xokdvium
force-pushed
the
nix-2.3-insecure-fix
branch
from
d5ae6a2 to
051290b
Compare
Ericson2314
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
25.05 has it marked as insecure, but we don't care about it for testing purposes.
Context
https://hydra.nixos.org/eval/1817769#tabs-removed
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.