libfetchers/git: add support for '.' in gitmodules#13757
Merged
roberth merged 1 commit intoNixOS:masterfrom Aug 18, 2025
Merged
libfetchers/git: add support for '.' in gitmodules#13757roberth merged 1 commit intoNixOS:masterfrom
roberth merged 1 commit intoNixOS:masterfrom
Conversation
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
xokdvium
reviewed
Aug 15, 2025
| // TODO: can this be an in-memory store somehow? | ||
| Path storeTmpDir = createTempDir(); | ||
| auto storeTmpDirAutoDelete = AutoDelete(storeTmpDir, true); | ||
| ref<Store> store = openStore(storeTmpDir); |
Contributor
There was a problem hiding this comment.
I think @Ericson2314 had a old PR to make dummy:// use more in-memory stuff. Would that be useful here? That never got merged.
Contributor
Author
There was a problem hiding this comment.
Discussed on matrix.
I will like to pick it up; seems worthwhile -- I might also make it a separate store.
Either way I think it doesn't block this PR.
fzakaria
commented
Aug 15, 2025
fzakaria
commented
Aug 15, 2025
xokdvium
reviewed
Aug 15, 2025
xokdvium
reviewed
Aug 15, 2025
xokdvium
reviewed
Aug 15, 2025
xokdvium
reviewed
Aug 15, 2025
Period '.' is a special branch name in the gitsubmodule file which represents the branch of the parent repository [1]. We add support for this by registering the ref of the InputAccessor to be that of the parent input if '.' is encountered. Fixes NixOS#13215 [1]: man gitmodules
roberth
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Please see #13215
Basically,
.gitmodulesfile may have.as the branch listed for a submodule.The git-documentation claims this is a "special" branch that represents it should be identical to the parent repository. [ref]
Validation
broken
fixed
Alternatively, I made a demo repo with this feature.
fixes #13215
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.