treewide: Remove getUri and replace with getHumanReadableURI where appropriate#13755
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Aug 14, 2025
Merged
treewide: Remove getUri and replace with getHumanReadableURI where appropriate#13755Ericson2314 merged 2 commits intoNixOS:masterfrom
Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
…propriate The problem with old code was that it used getUri for both the `diskCache` as well as logging. This is really bad because it mixes the textual human readable representation with the caching. Also using getUri for the cache key is really problematic for the S3 store, since it doesn't include the `endpoint` in the cache key, so it's totally broken. This starts separating the logging / cache concerns by introducing a `getHumanReadableURI` that should only be used for logging. The caching logic now instead uses `getReference().render(/*withParams=*/false)` exclusively. This would need to be fixed in follow-ups, because that's really fragile and broken for some store types (but it was already broken before).
github-actions
bot
added
new-cli
Ericson2314
reviewed
Aug 14, 2025
Ericson2314
reviewed
Aug 14, 2025
Ericson2314
reviewed
Aug 14, 2025
Ericson2314
reviewed
Aug 14, 2025
Contributor
Author
|
@Mic92, this addresses your concerns from #13734 (comment). |
Ericson2314
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The problem with old code was that it used getUri for both the
diskCacheas well as logging. This is really bad because it mixes the textual human
readable representation with the caching.
Also using getUri for the cache key is really problematic for the S3 store,
since it doesn't include the
endpointin the cache key, so it's totally broken.This starts separating the logging / cache concerns by introducing a
getHumanReadableURIthat should only be used for logging. The cachinglogic now instead uses
getReference().render(/*withParams=*/false)exclusively.This would need to be fixed in follow-ups, because that's really fragile and
broken for some store types (but it was already broken before).
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.