Merged
Conversation
github-actions
bot
added
fetching
xokdvium
reviewed
Aug 13, 2025
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I took a stab at it myself, but gitea defeated me. This is looking great already, but I do have some minor nitpicks and questions.
* Adds support for NIX_SSHOPTS * Properly uses the parsed port from URL (fixes NixOS#13337) * Don't guess the HTTP endpoint, use the response of git-lfs-authenticate * Add an SSH Git LFS test * Removed some unused test code
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NIX_SSHOPTSgit-lfs-authenticateContext
Fixes some outstanding issues with Git LFS and SSH. (See #13337 and the
FIXMEin the old code)For the tests, I had to change to clone from Gitea rather than pure SSH so that we can test fetching LFS files from an SSH server.
Also, renamed the
gitea_admintogitea_userin the tests since that user is not really an admin and it threw me for a loop until I realized why I was having issues with some of the Gitea API endpoints.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.