Skip to content

libutil: Fix i686-linux build on clangStdenv#13742

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
xokdvium:fix-i686
Aug 13, 2025
Merged

libutil: Fix i686-linux build on clangStdenv#13742
Mic92 merged 1 commit intoNixOS:masterfrom
xokdvium:fix-i686

Conversation

@xokdvium
Copy link
Contributor

Motivation

Clang refused to do a narrowing conversion in an initializer list:

 local-keys.cc:56:90: note: insert an explicit cast to silence this issue
return name + ":" + base64::encode(std::as_bytes(std::span<const unsigned char>{sig, sigLen}));
                                                                                    ^~~~~~
                                                                                    static_cast<size_type>( )

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Clang refused to do a narrowing conversion in an initializer list:

```
 local-keys.cc:56:90: note: insert an explicit cast to silence this issue
return name + ":" + base64::encode(std::as_bytes(std::span<const unsigned char>{sig, sigLen}));
                                                                                    ^~~~~~
                                                                                    static_cast<size_type>( )
```
@xokdvium xokdvium requested a review from Ericson2314 August 12, 2025 19:53
@xokdvium xokdvium requested a review from edolstra as a code owner August 12, 2025 19:53
@Mic92 Mic92 merged commit 68839b9 into NixOS:master Aug 13, 2025
14 checks passed
@xokdvium xokdvium deleted the fix-i686 branch August 13, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants