getUri should be const and on Store::Config not Store#13736
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Aug 11, 2025
Merged
getUri should be const and on Store::Config not Store#13736xokdvium merged 1 commit intoNixOS:masterfrom
getUri should be const and on Store::Config not Store#13736xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
xokdvium
reviewed
Aug 11, 2025
It is a side-effect property of the configuration alone, not the rest of the store.
Ericson2314
force-pushed
the
getUri-on-config
branch
from
8d07e33 to
0ef6f72
Compare
xokdvium
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It is a side-effect property of the configuration alone, not the rest of the store.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.