libfetchers: Remove badGitRefRegex and use libgit2 for reference validation#13729
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Aug 11, 2025
Merged
libfetchers: Remove badGitRefRegex and use libgit2 for reference validation#13729Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
with-tests
xokdvium
force-pushed
the
issue-13325
branch
2 times, most recently
from
8ea39ab to
9960ac8
Compare
…dation Fixes usage of `#` symbol in the reference name. This also seems to identify several deficiencies in the libgit2 refname validation code wrt to DEL symbol and a singular `@` symbol [1]. [1]: https://git-scm.com/docs/git-check-ref-format#_description
Mic92
approved these changes
Aug 11, 2025
2 tasks
This was referenced Aug 15, 2025
2 tasks
ysndr
added a commit
to flox/flox
that referenced
this pull request
Nov 6, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
Nov 6, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
Nov 6, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
Nov 6, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
Nov 7, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes usage of
#symbol in the reference name.This also seems to identify several deficiencies in the libgit2 refname validation code wrt to DEL symbol and a singular
@symbol 1.Context
Addresses #13325
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.