libutil: Move references.{hh,cc} to libstore, remove unused scanForReferences#13714
Merged
xokdvium merged 2 commits intoNixOS:masterfrom Aug 8, 2025
Merged
libutil: Move references.{hh,cc} to libstore, remove unused scanForReferences#13714xokdvium merged 2 commits intoNixOS:masterfrom
xokdvium merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
Ericson2314
approved these changes
Aug 8, 2025
This doesn't seem to be used anywhere at the moment. It might be used out-of-tree, but this is a small convenience function that is not worth keeping without in-tree usage.
The implicit dependency on refLength (which is the StorePath::HashLen) is not good. Also the companion tests and benchmarks are already in libstore-tests.
xokdvium
force-pushed
the
move-ref-scan-sink
branch
from
3c8b904 to
2e3ebfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The implicit dependency on refLength (which is the StorePath::HashLen)
is not good. Also the companion tests and benchmarks are already in libstore-tests.
The
scanForReferencesoverload doesn't seem to be used anywhere at the moment.It might be used out-of-tree, but this is a small convenience
function that is not worth keeping without in-tree usage.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.