treewide: Move private types and code into anonymous namespaces #13688
Merged
Mic92 merged 3 commits intoNixOS:masterfrom Aug 5, 2025
Merged
treewide: Move private types and code into anonymous namespaces #13688Mic92 merged 3 commits intoNixOS:masterfrom
Mic92 merged 3 commits intoNixOS:masterfrom
Conversation
Having a State class in the nix namespace is asking for ODR trouble. This class is already private to the translation unit, let's move it into an anonymous namespace.
Same as previous commit. This really should not be a part of the `nix` namespace. Otherwise the doxygen documentation is really confusing.
This code should be private to the corresponding translation units.
Mic92
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Having a class with a generic name like
Statein the nix namespace is askingfor ODR trouble, since it would blow up if another such class were to appear.
A lot of other library classes can be moved to anonymous namespaces. We could
start being a bit more principled about this. Maybe clang-tidy tooling can help
with this in the future?
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.