Skip to content

ci: Collect code coverage in tests#13686

Merged
xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium:ci-coverage
Aug 4, 2025
Merged

ci: Collect code coverage in tests#13686
xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium:ci-coverage

Conversation

@xokdvium
Copy link
Contributor

@xokdvium xokdvium commented Aug 4, 2025

Motivation

This adds the necessary infrastructure to collect
code coverage in CI, which could be useful to look at munually or track consistently via something like codecov.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This adds the necessary infrastructure to collect
code coverage in CI, which could be useful to look
at munually or track consistently via something like
codecov.

Co-authored-by: Jade Lovelace <lix@jade.fyi>
@xokdvium xokdvium requested review from Ericson2314 and Mic92 August 4, 2025 21:13
@xokdvium xokdvium requested a review from edolstra as a code owner August 4, 2025 21:13
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Aug 4, 2025
@xokdvium xokdvium enabled auto-merge August 4, 2025 21:20
@xokdvium xokdvium merged commit e5a8ee4 into NixOS:master Aug 4, 2025
14 checks passed
@edolstra
Copy link
Member

How can we see the result of these code coverage tests? How does it relate to the existing code coverage hydra job (https://hydra.nixos.org/build/305282505)?

@Mic92
Copy link
Member

Mic92 commented Aug 21, 2025

How can we see the result of these code coverage tests? How does it relate to the existing code coverage hydra job (https://hydra.nixos.org/build/305282505)?

Hydra is fixed in #13718

The motivation of this PR is to enable https://app.codecov.io/ so that we get feedback in pull requests on top of what hydra provides.

@xokdvium
Copy link
Contributor Author

How can we see the result of these code coverage tests? How does it relate to the existing code coverage hydra job (https://hydra.nixos.org/build/305282505)?

As @Mic92 mentioned above, this was before the coverage job was restored. As you can see from the metrics graph the job wasnt run at all, since we removed the autotools based system and moved to componentized builds. This PR was in preparation to restoring the hydra job you linked to. Recent runs of it upload the metrics/html that is collected by the infra added here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants