Encapsulate invalidBase32, avoid 0xFF magic number#13685
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Aug 4, 2025
Merged
Encapsulate invalidBase32, avoid 0xFF magic number#13685Ericson2314 merged 1 commit intoNixOS:masterfrom
invalidBase32, avoid 0xFF magic number#13685Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
This keeps things fast by making the function inline, but also prevents people from having to know about the `0xFF` implementation detail directly, instead making one go through a `std::optional` (which could be fused away with a sufficiently smart compiler). Additionally, the base "nix32" implementation is moved to its own header file pair, as it is logically distinct and prior to the `Hash` data type. It would probably be nice to do this with all the hash format implementations.
Ericson2314
force-pushed
the
hash-sentinal-encapsulation
branch
from
4dd20f6 to
23c87d8
Compare
xokdvium
reviewed
Aug 4, 2025
Comment on lines
+30
to
+31
| else | ||
| return digit; |
Contributor
There was a problem hiding this comment.
Suggested change
| else | |
| return digit; | |
| return digit; |
xokdvium
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This keeps things fast by making the function inline, but also prevents people from having to know about the
0xFFimplementation detail directly, instead making one go through astd::optional(which could be fused away with a sufficiently smart compiler).Additionally, the base "nix32" implementation is moved to its own header file pair, as it is logically distinct and prior to the
Hashdata type. It would probably be nice to do this with all the hash format implementations.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.