merge queue: embarking 2.29-maintenance (56069a9) and #13590 together#13653
Closed
mergify[bot] wants to merge 3 commits into2.29-maintenancefrom
Closed
merge queue: embarking 2.29-maintenance (56069a9) and #13590 together#13653mergify[bot] wants to merge 3 commits into2.29-maintenancefrom
mergify[bot] wants to merge 3 commits into2.29-maintenancefrom
Conversation
(cherry picked from commit f627b8c)
Commit b36637c set `__ETC_PROFILE_NIX_SOURCED` globally, but this is not enough to prevent the script from being run again by child shells, because the variable was not exported and thus not inherited by any child process. Exporting the variable also agrees with the bash scripts. Notably, the old behavior broke `nix develop -c fish` in some cases, because the profile bin directory got prepended to the path, causing binaries from the profile to override binareis from the devshell. (cherry picked from commit b9ed3ae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch 2.29-maintenance (56069a9) and #13590 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #13590.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:check-success=installer test on macoscheck-success=installer test on ubuntucheck-success=tests on macoscheck-success=tests on ubuntucheck-success=vm_testscheck-success = installer test on macoscheck-neutral = installer test on macoscheck-skipped = installer test on macoscheck-success = installer test on ubuntucheck-neutral = installer test on ubuntucheck-skipped = installer test on ubuntucheck-success = tests on macoscheck-neutral = tests on macoscheck-skipped = tests on macoscheck-success = tests on ubuntucheck-neutral = tests on ubuntucheck-skipped = tests on ubuntuRequired conditions to stay in the queue:
check-success = installer test on macoscheck-neutral = installer test on macoscheck-skipped = installer test on macoscheck-success = installer test on ubuntucheck-neutral = installer test on ubuntucheck-skipped = installer test on ubuntucheck-success = tests on macoscheck-neutral = tests on macoscheck-skipped = tests on macoscheck-success = tests on ubuntucheck-neutral = tests on ubuntucheck-skipped = tests on ubuntu