Make platform checks throw BuildError like other failures (backport #13278)#13603
Closed
mergify[bot] wants to merge 1 commit into2.28-maintenancefrom
Closed
Make platform checks throw BuildError like other failures (backport #13278)#13603mergify[bot] wants to merge 1 commit into2.28-maintenancefrom
mergify[bot] wants to merge 1 commit into2.28-maintenancefrom
Conversation
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com> (cherry picked from commit b04962b) # Conflicts: # src/libstore/unix/build/local-derivation-goal.cc
Contributor
Author
|
Cherry-pick of b04962b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Member
|
Closed because no one is catching up on all these backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some complex derivations can depend on multiple systems. In cases where these aren't already cached (or locally buildable), Nix throws an error indicating that a derivation cannot be built. However, this does not behave the same with respect to other build errors. This PR changes the error to throw
BuildError, allowing Nix to report the dependency tree that led to the build error, if any.In the examples below,
needs-*depends on a derivation that fails for the various scenarios I've tested locally.Mismatched system
Before:
After:
Missing required feature
Before:
After:
Rosetta not installed
(Note that I don't have a Mac to test on, but I've used --system passed to sudo nix build to generate this error.)
Before:
After:
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #13278 done by [Mergify](https://mergify.com).