meson: Fix nix_system_cpu for MIPS and 32 bit ARM systems#13558
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jul 26, 2025
Merged
meson: Fix nix_system_cpu for MIPS and 32 bit ARM systems#13558Ericson2314 merged 1 commit intoNixOS:masterfrom
nix_system_cpu for MIPS and 32 bit ARM systems#13558Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
Prior patches in 54dc531 and 6db6190 fixed the default system double for i686 and ppc/ppc64. This also patch also covers 32 bit arm and mips. ARM cpu names are taken from host_machine.cpu() for a lack of a better option, but host_machine.cpu_family() is preferred, since that is supposed to be somewhat standard for cross files. Endianness is handled correctly by looking at host_machine.endian(). This also updates the documentation to be up to date to how system cpu is translated from the host_machine specification.
Ericson2314
approved these changes
Jul 26, 2025
Member
|
Good to see the docs updated. |
xokdvium
added
backport 2.28-maintenance
This was referenced Jul 26, 2025
mergify bot
added a commit
that referenced
this pull request
Jul 27, 2025
…3558 meson: Fix `nix_system_cpu` for MIPS and 32 bit ARM systems (backport #13558)
mergify bot
added a commit
that referenced
this pull request
Jul 27, 2025
…3558 meson: Fix `nix_system_cpu` for MIPS and 32 bit ARM systems (backport #13558)
mergify bot
added a commit
that referenced
this pull request
Jul 27, 2025
…3558 meson: Fix `nix_system_cpu` for MIPS and 32 bit ARM systems (backport #13558)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Prior patches in 54dc531 and 6db6190 fixed the default system double for i686 and ppc/ppc64. This also patch also covers 32 bit arm and mips. ARM cpu names are taken from
host_machine.cpu()for a lack of a better option, buthost_machine.cpu_family()is preferred, since that is supposed to be somewhat standard for cross files. Endianness is handled correctly by looking athost_machine.endian().This also updates the documentation to be up to date to how system cpu is translated from the host_machine specification.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.