Add functional test for no-url-literals experimental feature#13555
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Aug 6, 2025
Merged
Add functional test for no-url-literals experimental feature#13555xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
with-tests
Member
|
Hi, thanks for this. Can you see how the stdout/stderr files are avoided in other tests with pipes, and the |
Ericson2314
previously requested changes
Jul 30, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Try to avoid so many intermediate files.
oknyshuk
force-pushed
the
no-url-literals-test
branch
from
51738f2 to
6e8f764
Compare
Contributor
Author
|
Hey, thanks for reviewing this. Is it better now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This experimental feature has been untested since it's addition. It's easy to cover it, so I did that.
Sorry if the test's suboptimal, I don't have much experience.
Context
Closes: #13533
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.