Skip to content

meson: Correctly handle endianness for PowerPC CPU families (backport #13520)#13529

Merged
mergify[bot] merged 1 commit into2.30-maintenancefrom
mergify/bp/2.30-maintenance/pr-13520
Jul 23, 2025
Merged

meson: Correctly handle endianness for PowerPC CPU families (backport #13520)#13529
mergify[bot] merged 1 commit into2.30-maintenancefrom
mergify/bp/2.30-maintenance/pr-13520

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 23, 2025

Motivation

I've missed this while reviewing 6db6190. I only built big endian ppc64, so that didn't occur to me.

From meson manual:

Those porting from autotools should note that Meson does not add
endianness to the name of the cpu_family. For example, autotools will
call little endian PPC64 "ppc64le", Meson will not, you must also check
the .endian() value of the machine for this information.

This code should handle that correctly.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


This is an automatic backport of pull request #13520 done by [Mergify](https://mergify.com).

I've missed this while reviewing 6db6190.
I only built big endian ppc64, so that didn't occur to me.

From meson manual:

> Those porting from autotools should note that Meson does not add
> endianness to the name of the cpu_family. For example, autotools will
> call little endian PPC64 "ppc64le", Meson will not, you must also check
> the .endian() value of the machine for this information.

This code should handle that correctly.

(cherry picked from commit ebd311b)
@mergify mergify bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue labels Jul 23, 2025
@mergify mergify bot requested a review from edolstra as a code owner July 23, 2025 20:36
@mergify mergify bot added merge-queue automatic backport This PR is a backport produced by automation (does not trigger backporting) labels Jul 23, 2025
@mergify mergify bot merged commit 8eaa838 into 2.30-maintenance Jul 23, 2025
27 checks passed
@mergify mergify bot deleted the mergify/bp/2.30-maintenance/pr-13520 branch July 23, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant