meson: Correctly handle endianness for PowerPC CPU families (backport #13520)#13528
Closed
mergify[bot] wants to merge 1 commit into2.29-maintenancefrom
Closed
meson: Correctly handle endianness for PowerPC CPU families (backport #13520)#13528mergify[bot] wants to merge 1 commit into2.29-maintenancefrom
mergify[bot] wants to merge 1 commit into2.29-maintenancefrom
Conversation
I've missed this while reviewing 6db6190. I only built big endian ppc64, so that didn't occur to me. From meson manual: > Those porting from autotools should note that Meson does not add > endianness to the name of the cpu_family. For example, autotools will > call little endian PPC64 "ppc64le", Meson will not, you must also check > the .endian() value of the machine for this information. This code should handle that correctly. (cherry picked from commit ebd311b)
mergify
bot
added
the
automatic backport
mergify
bot
added
merge-queue
automatic backport
Member
|
Included in #13540. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I've missed this while reviewing 6db6190. I only built big endian ppc64, so that didn't occur to me.
From meson manual:
This code should handle that correctly.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #13520 done by [Mergify](https://mergify.com).