Merged
Conversation
This adds a GHA jobs to help analyze build times and its regressions. It is based on `clangStdenv` with `-ftime-trace` together with `ClangBuildAnalyzer` to prepare markdown summary for individual components. This also has the minor benefit of dogfooding CA and impure derivations.
Contributor
Author
|
Example of the summary: https://github.com/xokdvium/nix/actions/runs/16401423399 |
xokdvium
added
the
contributor-experience
roberth
approved these changes
Jul 21, 2025
| } | ||
| ); | ||
|
|
||
| componentsToProfile = { |
Member
There was a problem hiding this comment.
We should come up with something a bit nicer than hardcoding lists like this over and over, but that'd be a separate task.
| buildTimeReport = | ||
| pkgs.runCommand "build-time-report" | ||
| { | ||
| __impure = true; |
| mesonComponentOverrides = finalAttrs: prevAttrs: { | ||
| outputs = (prevAttrs.outputs or [ "out" ]) ++ [ "buildprofile" ]; | ||
| nativeBuildInputs = [ pkgs.clangbuildanalyzer ] ++ prevAttrs.nativeBuildInputs or [ ]; | ||
| __impure = true; |
Member
There was a problem hiding this comment.
@edolstra in the magic action, it'd be good to avoid saving impure paths, because they can't be reused anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds a GHA jobs to help analyze build times
and its regressions. It is based on
clangStdenvwith-ftime-tracetogether withClangBuildAnalyzerto prepare markdown summary for individual components.The job is only run on the master branch on pushes. Not sure that running this job for all PRs is worthwhile.
This also has the minor benefit of dogfooding CA and impure derivations.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.