Require rsync in nix-manual meson.build#13501
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Jul 17, 2025
Merged
Conversation
xokdvium
reviewed
Jul 17, 2025
oknyshuk
force-pushed
the
fix-rsync-requirement
branch
from
524b572 to
cfb8a31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When building the nix-manual meson subproject a custom target is defined using a shell script that invokes rsync. Despite that, rsync is never required by meson and configuration still succeeds if no rsync is on the system.
Context
Closes: #13313
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.