Add helpful messages when file:// used as tarball#13486
Merged
tomberek merged 1 commit intoNixOS:masterfrom Jul 17, 2025
Merged
Add helpful messages when file:// used as tarball#13486tomberek merged 1 commit intoNixOS:masterfrom
tomberek merged 1 commit intoNixOS:masterfrom
Conversation
When `file://` is used accidentally in a flake as the source it is expected to be a tarball by default. Add some friendlier error messages to either inform the user this is not in fact a tarball or if it's a git directory, let them know they can use `git+file`. fixes NixOS#12935
tomberek
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
file://is used accidentally in a flake as the source it is expected to be a tarball by default.Add some friendlier error messages to either inform the user this is not in fact a tarball or if it's a git directory, let them know they can use
git+file.Please see #12935 for more in depth motivation.
fixes #12935
Validation
** Missing directory **
** directory BUT is git **
** directory BUT is NOT git **
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.