libstore: fix Unix sockets in the build directory on sandboxed macOS#13468
Merged
edolstra merged 1 commit intoNixOS:masterfrom Jul 14, 2025
Merged
libstore: fix Unix sockets in the build directory on sandboxed macOS#13468edolstra merged 1 commit intoNixOS:masterfrom
edolstra merged 1 commit intoNixOS:masterfrom
Conversation
We’re already allowing `/tmp` anyway, so this should be harmless, and it fixes a regression in the default configuration caused by moving the build directories out of `temp-dir`. (For instance, that broke the Lix `guessOrInventPath.sockets` test.) Note that removing `/tmp` breaks quite a few builds, so although it may be a good idea in general it would require work on the Nixpkgs side. Fixes: 749afbb Change-Id: I6a6a69645f429bc50d4cb24283feda3d3091f534 (This is a cherry-pick of commit d1db3e5) Lix patch: https://gerrit.lix.systems/c/lix/+/3500
Contributor
Author
|
Tested by dogfooding the nix master in our CI: https://github.com/xokdvium/nix/actions/runs/16251441092/job/45881663855 |
Closed
edolstra
added
the
backport 2.30-maintenance
edolstra
added a commit
that referenced
this pull request
Jul 14, 2025
…3468 libstore: fix Unix sockets in the build directory on sandboxed macOS (backport #13468)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We’re already allowing
/tmpanyway, so this should be harmless, and it fixes a regression in the default configuration caused by moving the build directories out oftemp-dir. (For instance, that broke the LixguessOrInventPath.socketstest.)Note that removing
/tmpbreaks quite a few builds, so although it may be a good idea in general it would require work on the Nixpkgs side.Context
(This is a cherry-pick of commit d1db3e5)
Lix patch: https://gerrit.lix.systems/c/lix/+/3500
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.