Skip to content

Better Handling for Expired Credentials#13460

Merged
edolstra merged 3 commits intoNixOS:masterfrom
m4dc4p:m4dc4p/handle-expired-tokens
Jul 14, 2025
Merged

Better Handling for Expired Credentials#13460
edolstra merged 3 commits intoNixOS:masterfrom
m4dc4p:m4dc4p/handle-expired-tokens

Conversation

@m4dc4p
Copy link
Contributor

@m4dc4p m4dc4p commented Jul 12, 2025

When AWS credentials expired, in some scenarios they led to the nix process aborting with an error similar to ' Unable to parse ExceptionName: ExpiredToken'.

This change updates the S3 handling code such that those errors are treated like 403s or 404s.

Closes #13459

Please see that issue for more detail.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

When AWS credentials expired, in some scenarios they led to the
nix process aborting with an error similar to ' Unable to parse ExceptionName: ExpiredToken'.

This change updates the S3 handling code such that those errors are treated like 403s or 404s.

Closes NixOS#13459
@m4dc4p m4dc4p requested a review from Ericson2314 as a code owner July 12, 2025 00:31
@github-actions github-actions bot added the store Issues and pull requests concerning the Nix store label Jul 12, 2025
Copy link
Member

@edolstra edolstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

m4dc4p and others added 2 commits July 12, 2025 08:05
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
@edolstra edolstra enabled auto-merge July 14, 2025 09:12
@edolstra edolstra merged commit e8314e6 into NixOS:master Jul 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

store Issues and pull requests concerning the Nix store

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better handling of expired credentials w/ AWS & S3 substituter

3 participants