libexpr: Fix invalid handling of errors for imported functions (backport #13450)#13453
Merged
xokdvium merged 1 commit into2.30-maintenancefrom Jul 11, 2025
Merged
Conversation
c39cc00 has added assertions for all Value accesses and the following case has started failing with an `unreachable`: (/tmp/fun.nix): ```nix {a}: a ``` ``` $ nix eval --impure --expr 'import /tmp/fun.nix {a="a";b="b";}' ``` This would crash: ``` terminating due to unexpected unrecoverable internal error: Unexpected condition in getStorage at ../include/nix/expr/value.hh:844 ``` This is not a regression, but rather surfaces an existing problem, which previously was left undiagnosed. In the case of an import `fun` is the `import` primOp, so that read is invalid and previously this resulted in an access into an inactive union member, which is UB. The correct thing to use is `vCur`. Identical problem also affected the case of a missing argument. Add previously failing test cases to the functional/lang test suite. Fixes #13448. (cherry picked from commit 6e78cc9)
mergify
bot
added
automatic backport
github-actions
bot
added
the
with-tests
Contributor
Author
|
This pull request has been removed from the queue for the following reason: Pull request #13453 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "tests on ubuntu" is in progress.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
c39cc00 has added assertions for all Value accesses and the following case has started failing with an
unreachable:(/tmp/fun.nix):
This would crash:
This is not a regression, but rather surfaces an existing problem, which previously was left undiagnosed. In the case of an import
funis theimportprimOp, so that read is invalid and previously this resulted in an access into an inactive union member, which is UB. The correct thing to use isvCur. Identical problem also affected the case of a missing argument.Add previously failing test cases to the functional/lang test suite.
Context
Fixes #13448.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #13450 done by [Mergify](https://mergify.com).