Skip to content

Require Boost 1.82.0 or higher#13442

Merged
edolstra merged 3 commits intomasterfrom
boost-minver
Jul 16, 2025
Merged

Require Boost 1.82.0 or higher#13442
edolstra merged 3 commits intomasterfrom
boost-minver

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Jul 10, 2025

Motivation

Slight cleanup to remove legacy code.

Note: this version of Boost was released in April 2023.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

edolstra added 2 commits July 10, 2025 11:53
Note: this version of Boost was released in December 2022.
@edolstra edolstra changed the title Require Boost 1.81.0 or higher Require Boost 1.82.0 or higher Jul 10, 2025
@xokdvium
Copy link
Contributor

@edolstra, we should probably bump the required version in all meson subprojects, not just libexpr. Also I think I brought up that we shouldn't really support boost <= 1.82 in the symbol table pr #13258 (comment).

@edolstra
Copy link
Member Author

I think it's enough to test it in one subproject since it will fail the entire build if the condition in libexpr isn't met.

Do you mean boost <= 1.82 or boost < 1.82?

@Ericson2314
Copy link
Member

The min versions can be different, but should reflect the actual need of the project in question.

That means the libutil needs to also require what it needs (i.e. avoid the broken versions, e.g. by requiring the fixed version as a minimum) but libstore etc. don't need to be changed.

Comment on lines -197 to -199
#if BOOST_VERSION >= 106300 && BOOST_VERSION < 106600
#error Coroutines are broken in this version of Boost!
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So please turn that into a src/libutil/meson.build somehow per the above, otherwise this looks good to me.

@edolstra
Copy link
Member Author

Putting boost version requirements in every subprojects seems unmaintainable and unnecessary code duplication. But we could put a check in libutil since everything else depends on it.

@edolstra
Copy link
Member Author

I've moved the version check to libutil.

Copy link
Contributor

@xokdvium xokdvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This is much more maintainable!

@edolstra edolstra merged commit 1272c49 into master Jul 16, 2025
25 checks passed
@edolstra edolstra deleted the boost-minver branch July 16, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants