Conversation
Note: this version of Boost was released in December 2022.
|
@edolstra, we should probably bump the required version in all meson subprojects, not just |
|
I think it's enough to test it in one subproject since it will fail the entire build if the condition in libexpr isn't met. Do you mean boost <= 1.82 or boost < 1.82? |
|
The min versions can be different, but should reflect the actual need of the project in question. That means the libutil needs to also require what it needs (i.e. avoid the broken versions, e.g. by requiring the fixed version as a minimum) but libstore etc. don't need to be changed. |
| #if BOOST_VERSION >= 106300 && BOOST_VERSION < 106600 | ||
| #error Coroutines are broken in this version of Boost! | ||
| #endif |
There was a problem hiding this comment.
So please turn that into a src/libutil/meson.build somehow per the above, otherwise this looks good to me.
|
Putting boost version requirements in every subprojects seems unmaintainable and unnecessary code duplication. But we could put a check in libutil since everything else depends on it. |
|
I've moved the version check to libutil. |
xokdvium
left a comment
There was a problem hiding this comment.
Makes sense. This is much more maintainable!
Motivation
Slight cleanup to remove legacy code.
Note: this version of Boost was released in April 2023.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.