installers, tests: remove --preserve=mode from cp invocations#13427
Merged
edolstra merged 1 commit intoNixOS:masterfrom Jul 8, 2025
Merged
installers, tests: remove --preserve=mode from cp invocations#13427edolstra merged 1 commit intoNixOS:masterfrom
edolstra merged 1 commit intoNixOS:masterfrom
Conversation
jsoo1
force-pushed
the
remove-p
branch
2 times, most recently
from
efaedcd to
bd0f1a5
Compare
-p preserves xattrs and acls which can be incompatible between filesystems Unfortunately keep -p on darwin because the bsd coreutils do not support --preserve. Fixes NixOS#13426
edolstra
added
the
backport 2.30-maintenance
edolstra
added a commit
that referenced
this pull request
Jul 8, 2025
…3427 installers, tests: remove --preserve=mode from cp invocations (backport #13427)
Member
|
Looks like this broke installations on Linux distros that use busybox as their |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-p preserves xattrs and acls which can be incompatible between filesystems
Note that
--preserve=ownershipcan also be problematic on NFS because of the root-squashing mechanism.Fixes #13426