Skip to content

libstore-tests: Don't leak memory in tests#13395

Merged
roberth merged 1 commit intoNixOS:masterfrom
xokdvium:libstore-tests-leaks
Jun 25, 2025
Merged

libstore-tests: Don't leak memory in tests#13395
roberth merged 1 commit intoNixOS:masterfrom
xokdvium:libstore-tests-leaks

Conversation

@xokdvium
Copy link
Contributor

Motivation

We shouldn't leak memory in unit tests in order
to make enabling ASAN easier.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

We shouldn't leak memory in unit tests in order
to make enabling ASAN easier.
@xokdvium xokdvium requested a review from edolstra as a code owner June 24, 2025 21:32
@github-actions github-actions bot added the c api Nix as a C library with a stable interface label Jun 24, 2025
@xokdvium xokdvium requested a review from Ericson2314 June 24, 2025 21:33
@roberth roberth merged commit df2d5f2 into NixOS:master Jun 25, 2025
12 checks passed
@xokdvium xokdvium deleted the libstore-tests-leaks branch June 25, 2025 21:06
@roberth roberth added backports created Does not require attention and can be filtered away backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch labels Jul 30, 2025
mergify bot added a commit that referenced this pull request Jul 31, 2025
…3395

libstore-tests: Don't leak memory in tests (backport #13395)
mergify bot added a commit that referenced this pull request Jul 31, 2025
…3395

libstore-tests: Don't leak memory in tests (backport #13395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away c api Nix as a C library with a stable interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants