libexpr: Remove non-const overload of listElems#13360
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Jun 13, 2025
Merged
Conversation
This overload isn't actually necessary anywhere and doesn't make much sense. The pointers to `Value`s are themselves const, but the `Value`s are mutable. A non-const member function implies that the object itself can be modified but this doesn't make much sense considering the return type: `Value * const * `, which is a pointer to a constant array of pointers to mutable values.
roberth
added
backports created
This was referenced Jul 30, 2025
mergify bot
added a commit
that referenced
this pull request
Jul 31, 2025
…3360 libexpr: Remove non-const overload of `listElems` (backport #13360)
mergify bot
added a commit
that referenced
this pull request
Jul 31, 2025
…3360 libexpr: Remove non-const overload of `listElems` (backport #13360)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This overload isn't actually necessary anywhere and doesn't make much sense. The pointers to
Values are themselves const, but theValues are mutable.A non-const member function implies that the object itself can be modified but this doesn't make much sense considering the return type:
Value * const *, which is a pointer to a constant array of pointers to mutable values.cc @roberth, @edolstra as you've been cleaning up the meaning of const throughout the codebase.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.