Skip to content

docker.nix: Prevent double copy of nixpkgs source tree#13326

Merged
Mic92 merged 1 commit intomasterfrom
no-double-copy
Jun 6, 2025
Merged

docker.nix: Prevent double copy of nixpkgs source tree#13326
Mic92 merged 1 commit intomasterfrom
no-double-copy

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Jun 5, 2025

Motivation

This avoids a double copy of Nixpkgs (resulting in /nix/store/<hash>-<hash>-source).

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@Ericson2314
Copy link
Member

Hmm, did path in Nixpkgs used to be a string? Feel like this wasn't a problem before.

@Mic92 Mic92 merged commit 540db80 into master Jun 6, 2025
25 checks passed
@Mic92 Mic92 deleted the no-double-copy branch June 6, 2025 08:09
@Mic92
Copy link
Member

Mic92 commented Jun 6, 2025

Hmm, did path in Nixpkgs used to be a string? Feel like this wasn't a problem before.

well if you used it was introducing a eval impurity and if you use flake it does a copy as @edolstra said.

@roberth roberth added backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away labels Jul 30, 2025
mergify bot added a commit that referenced this pull request Jul 30, 2025
…3326

docker.nix: Prevent double copy of nixpkgs source tree (backport #13326)
mergify bot added a commit that referenced this pull request Jul 31, 2025
…3326

docker.nix: Prevent double copy of nixpkgs source tree (backport #13326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants