Skip to content

Modify docker.nix to use mapAttrsToList instead of mapAttrsFlatten#13321

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
poperigby:docker-map-attrs-flatten-replacement
Jun 4, 2025
Merged

Modify docker.nix to use mapAttrsToList instead of mapAttrsFlatten#13321
Mic92 merged 1 commit intoNixOS:masterfrom
poperigby:docker-map-attrs-flatten-replacement

Conversation

@poperigby
Copy link
Contributor

The latter alias is deprecated in favor of the former, and produces a warning.

Motivation

docker.nix currently produces a warning:

lib.misc.mapAttrsFlatten is deprecated, please use lib.attrsets.mapAttrsToList instead

This PR fixes it by changing the function to mapAttrsToList.

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

The latter alias is deprecated in favor of the former, and produces a
warning.
@poperigby poperigby requested a review from edolstra as a code owner June 3, 2025 20:28
@Mic92
Copy link
Member

Mic92 commented Jun 4, 2025

Thanks!

@Mic92 Mic92 merged commit 4751cbe into NixOS:master Jun 4, 2025
12 checks passed
@roberth roberth added backports created Does not require attention and can be filtered away backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch labels Jul 30, 2025
mergify bot added a commit that referenced this pull request Jul 31, 2025
…3321

Modify docker.nix to use mapAttrsToList instead of mapAttrsFlatten (backport #13321)
mergify bot added a commit that referenced this pull request Jul 31, 2025
…3321

Modify docker.nix to use mapAttrsToList instead of mapAttrsFlatten (backport #13321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants