Merged
Conversation
This was referenced May 29, 2025
This comment was marked as resolved.
This comment was marked as resolved.
It currently fails, before the fix.
github-actions
bot
added
the
with-tests
We move the `assertPathValidity` to where we know what the wanted outputs are.
This comment was marked as resolved.
This comment was marked as resolved.
xokdvium
approved these changes
Jun 11, 2025
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Test case fails without the second commit and passes with the second one. Seems good to me. Not sure about all of the implementation details though.
roberth
added
the
backports created
Member
|
Should this be backported? |
Member
Author
|
I am not sure. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
We move the
assertPathValidityto where we know what the wanted outputs are.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.