Merged
Conversation
Since the migration to meson precompiled-headers.h isn't actually used anymore and is just confusing. Meson can't handle shared pch across subprojects [1] and without that there's no performances benefit of PCH at all. Also rolling our own support for that isn't trivial. See [2] for an example of how that would look like. [1]: mesonbuild/meson#4350 [2]: https://github.com/WayfireWM/wayfire/blob/22bc8b647351c45829baac570b828c8f852111dc/plugins/meson.build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since the migration to meson precompiled-headers.h isn't actually used anymore and is just confusing. Meson can't handle shared pch across subprojects 1 and without that there's no performances benefit of PCH at all. Also rolling our own support for that isn't trivial. See 2 for an example of how that would look like.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.