tests/functional: Add more language tests for builtins.match#13282
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom May 28, 2025
Merged
tests/functional: Add more language tests for builtins.match#13282Ericson2314 merged 1 commit intoNixOS:masterfrom
builtins.match#13282Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
These tests have been collected from nixpkgs f870c6ccc8951fc48aeb293cf3e98ade6ac42668 usage of builtins.match for x86_64-linux eval system. At most 2 matching and non-matching cases are included for each encountered regex. This should hopefully add more confidence when possibly trying to switch the regex implementation in the future.
github-actions
bot
added
the
with-tests
edolstra
approved these changes
May 28, 2025
tomberek
approved these changes
May 28, 2025
roberth
added
backports created
This was referenced Jul 30, 2025
mergify bot
added a commit
that referenced
this pull request
Jul 31, 2025
…3282 tests/functional: Add more language tests for `builtins.match` (backport #13282)
mergify bot
added a commit
that referenced
this pull request
Jul 31, 2025
…3282 tests/functional: Add more language tests for `builtins.match` (backport #13282)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These tests have been collected from nixpkgs f870c6ccc8951fc48aeb293cf3e98ade6ac42668 usage of
builtins.matchfor x86_64-linux eval system. At most 2 matching and non-matching cases are included for each encountered regex. This should hopefully add more confidence when possibly trying to switch the regex implementation in the future.Context
To get more real-world usage coverage to hopefully avoid regressions like #7762.
Should this need nixpkgs license attribution?
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.