Conversation
The cache is now part of fetchers::Settings.
Member
|
@edolstra Thank you for joining me in the war against global variables! :) |
Member
This has been done before, and I'm not too worried about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This removes the global fetcher cache object (the
getCache()singleton) and moves the cache intofetchers::Settings. This is a bit of an abuse offetchers::Settingsbut I didn't want to add another class to pass around everywhere.Context
This is cherry-picked from DeterminateSystems#49, which adds a
builtin:fetch-treebuiltin builder. Since builtin builders run in a forked child process, we cannot use any of the parent's global state (like the fetcher cache's SQLite database) since that's invalid in the child (e.g. it refers to file handles that don't exist in the child). Thus we use a newfetchers::Settingsobject to avoid touching the parent's fetcher cache.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.