packaging: Use correct stdenv for x86_64-darwin#12557
Merged
roberth merged 1 commit intoNixOS:masterfrom Feb 24, 2025
Merged
Conversation
roberth
added
the
build-problem
roberth
commented
Feb 24, 2025
Comment on lines
+14
to
+22
| inherit | ||
| (scope.callPackage ( | ||
| { stdenv }: | ||
| { | ||
| inherit stdenv; | ||
| } | ||
| ) { }) | ||
| stdenv | ||
| ; |
Member
Author
There was a problem hiding this comment.
Not pretty. Will consider moving the build utilities to their own file, and then callPackage that.
Member
Author
There was a problem hiding this comment.
Either way we aren't making much use of the two layers of scoping, and we could simplify by squashing those into one scope. I'd keep the separate file for dependencies, but wire it up with import and // - should be simple enough.
edolstra
approved these changes
Feb 24, 2025
edolstra
added a commit
that referenced
this pull request
Feb 24, 2025
…2557 packaging: Use correct stdenv for x86_64-darwin (backport #12557)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-02-24-nix-team-meeting-minutes-215-216/60920/1 |
Mic92
pushed a commit
to roberth/nixpkgs
that referenced
this pull request
Mar 11, 2025
sandptel
pushed a commit
to sandptel/nixpkgs
that referenced
this pull request
Mar 13, 2025
Ericson2314
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Mar 16, 2025
See NixOS/nix#12557 (cherry picked from commit e4d9c99)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
x86-64_darwinrunner #11144Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.