Draft
Conversation
These are some small improvements gathered while working on Nixpkgs packaging, NixOS/nixpkgs#383508. They're low hanging fruit, while the Nixpkgs packaging is still in flux (e.g. filesets aren't appreciated, nor is the everything.nix multi-derivation package) This makes the files more readily transferable.
roberth
commented
Feb 20, 2025
| '' | ||
| + '' | ||
| export _NIX_TEST_UNIT_DATA=${data + "/src/libstore-tests/data"} | ||
| export _NIX_TEST_UNIT_DATA=${resolvePath ./data/src/libstore-tests/data} |
Member
Author
There was a problem hiding this comment.
This worked in Nixpkgs, but not here. Might need a more explicit conditional, since we don't have the "source layer" to do the work for us in this case.
Member
Author
There was a problem hiding this comment.
Or expose the "source layer" logic (or similar) as an independent function.
Member
Author
|
Obsolete + keeping Nixpkgs files exactly in sync is not a goal anymore. |
Member
|
Well, long term I hope we can go back to keeping in sync, but yes, it will be a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some small improvements gathered while working on Nixpkgs packaging, NixOS/nixpkgs#383508. They're low hanging fruit, while the Nixpkgs packaging is still in flux (e.g. filesets aren't appreciated, nor is the everything.nix multi-derivation package)
This makes the files more readily transferable.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.