EvalState::resolveLookupPathPath(): Call resolveSymlinks() before pathExists() #12347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
roberth
approved these changes
Jan 24, 2025
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Classic. We should change the interface so that low level methods like pathExists() aren't the default pick.
Ok fix though.
mergify bot
added a commit
that referenced
this pull request
Jan 24, 2025
…2347 EvalState::resolveLookupPathPath(): Call resolveSymlinks() before pathExists() (backport #12347)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #12339. This was broken in af07f33.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.