Skip to content

libutil: handle json builder log messages with unexpected format#11939

Closed
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92:libutil
Closed

libutil: handle json builder log messages with unexpected format#11939
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92:libutil

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 23, 2024

@Mic92 Mic92 requested a review from edolstra as a code owner November 23, 2024 08:08
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Nov 23, 2024
@tomberek
Copy link
Contributor

Carved out the compression-levels failure. Not sure how it is related or if it helps:

Details
nix-tests>  79/181 nix-functional-tests:main / compression-levels                               FAIL             1.09s   exit status 1
nix-tests> >>> MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=77 NIX_REMOTE='' TEST_NAME=main/compression-levels PS4='+(${BASH_SOURCE[0]-$0}:$LINENO) ' ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 _NIX_TEST_BUILD_DIR=/build/source/tests/functional/build _NIX_TEST_SOURCE_DIR=/build/source/tests/functional UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /nix/store/wckka8fxv4h5hp74cbkhaw3fw7kbvcs1-bash-5.2p26/bin/bash -x -e -u -o pipefail compression-levels.sh
nix-tests>  ✀
nix-tests> Listing only the last 100 lines from a long log.
nix-tests> +++(/build/source/tests/functional/common/vars.sh:61) unset XDG_CONFIG_DIRS
nix-tests> +++(/build/source/tests/functional/common/vars.sh:62) unset XDG_CACHE_HOME
nix-tests> +++(/build/source/tests/functional/common/vars.sh:64) export IMPURE_VAR1=foo
nix-tests> +++(/build/source/tests/functional/common/vars.sh:64) IMPURE_VAR1=foo
nix-tests> +++(/build/source/tests/functional/common/vars.sh:65) export IMPURE_VAR2=bar
nix-tests> +++(/build/source/tests/functional/common/vars.sh:65) IMPURE_VAR2=bar
nix-tests> +++(/build/source/tests/functional/common/vars.sh:69) cacheDir=/build/nix-test/main/compression-levels/binary-cache
nix-tests> ++++(/build/source/tests/functional/common/vars.sh:71) uname
nix-tests> +++(/build/source/tests/functional/common/vars.sh:71) [[ Linux == Linux ]]
nix-tests> +++(/build/source/tests/functional/common/vars.sh:71) [[ -L /proc/self/ns/user ]]
nix-tests> +++(/build/source/tests/functional/common/vars.sh:71) unshare --user true
nix-tests> +++(/build/source/tests/functional/common/vars.sh:72) _canUseSandbox=1
nix-tests> +++(/build/source/tests/functional/common/vars.sh:78) config_nix=/build/source/tests/functional/build/config.nix
nix-tests> ++(common.sh:12) source /build/source/tests/functional/common/functions.sh
nix-tests> +++(/build/source/tests/functional/common/functions.sh:3) set -eu -o pipefail
nix-tests> +++(/build/source/tests/functional/common/functions.sh:5) [[ -z 1 ]]
nix-tests> ++(common.sh:13) source /build/source/tests/functional/common/init.sh
nix-tests> +++(/build/source/tests/functional/common/init.sh:4) : /build/nix-test/main/compression-levels/etc /build/nix-test/main/compression-levels/etc/nix.conf
nix-tests> +++(/build/source/tests/functional/common/init.sh:6) isTestOnNixOS
nix-tests> +++(/build/source/tests/functional/common/functions.sh:10) [[ '' == 1 ]]
nix-tests> +++(/build/source/tests/functional/common/init.sh:29) test -n /build/nix-test/main/compression-levels
nix-tests> +++(/build/source/tests/functional/common/init.sh:31) killDaemon
nix-tests> +++(/build/source/tests/functional/common/functions.sh:96) isTestOnNixOS
nix-tests> +++(/build/source/tests/functional/common/functions.sh:10) [[ '' == 1 ]]
nix-tests> +++(/build/source/tests/functional/common/functions.sh:101) [[ '' == '' ]]
nix-tests> +++(/build/source/tests/functional/common/functions.sh:102) return
nix-tests> +++(/build/source/tests/functional/common/init.sh:33) [[ -e /build/nix-test/main/compression-levels ]]
nix-tests> +++(/build/source/tests/functional/common/init.sh:37) mkdir -p /build/nix-test/main/compression-levels
nix-tests> +++(/build/source/tests/functional/common/init.sh:38) mkdir /build/nix-test/main/compression-levels/test-home
nix-tests> +++(/build/source/tests/functional/common/init.sh:40) mkdir /build/nix-test/main/compression-levels/store
nix-tests> +++(/build/source/tests/functional/common/init.sh:41) mkdir /build/nix-test/main/compression-levels/var
nix-tests> +++(/build/source/tests/functional/common/init.sh:42) mkdir -p /build/nix-test/main/compression-levels/var/log/nix/drvs
nix-tests> +++(/build/source/tests/functional/common/init.sh:43) mkdir /build/nix-test/main/compression-levels/var/nix
nix-tests> +++(/build/source/tests/functional/common/init.sh:44) mkdir /build/nix-test/main/compression-levels/etc
nix-tests> +++(/build/source/tests/functional/common/init.sh:46) cat
nix-tests> ++++(/build/source/tests/functional/common/init.sh:46) whoami
nix-tests> +++(/build/source/tests/functional/common/init.sh:59) cat
nix-tests> +++(/build/source/tests/functional/common/init.sh:67) nix-store --init
nix-tests> +++(/build/source/tests/functional/common/init.sh:69) test -e /build/nix-test/main/compression-levels/var/nix/db/db.sqlite
nix-tests> ++(common.sh:15) [[ -n /nix/store/pd1rj7ay43l2xbraxjydjqvi30izqs7f-nix-2.22.3 ]]
nix-tests> ++(common.sh:16) startDaemon
nix-tests> ++(/build/source/tests/functional/common/functions.sh:66) isTestOnNixOS
nix-tests> ++(/build/source/tests/functional/common/functions.sh:10) [[ '' == 1 ]]
nix-tests> ++(/build/source/tests/functional/common/functions.sh:71) [[ '' != '' ]]
nix-tests> ++(/build/source/tests/functional/common/functions.sh:75) rm -f /build/nix-test/main/compression-levels/dSocket
nix-tests> ++(/build/source/tests/functional/common/functions.sh:77) _NIX_TEST_DAEMON_PID=11733
nix-tests> ++(/build/source/tests/functional/common/functions.sh:78) export _NIX_TEST_DAEMON_PID
nix-tests> ++(/build/source/tests/functional/common/functions.sh:79) (( i = 0 ))
nix-tests> ++(/build/source/tests/functional/common/functions.sh:79) (( i < 300 ))
nix-tests> ++(/build/source/tests/functional/common/functions.sh:80) [[ -S /build/nix-test/main/compression-levels/dSocket ]]
nix-tests> ++(/build/source/tests/functional/common/functions.sh:84) sleep 0.1
nix-tests> ++(/build/source/tests/functional/common/functions.sh:76) PATH=/nix/store/pd1rj7ay43l2xbraxjydjqvi30izqs7f-nix-2.22.3/bin:/nix/store/i9pskh64xj3z9g64vr0aa79lis66f1dw-nix-2.26.0pre20241123_7fe80d1/bin:/nix/store/sszlpg1ckgfdkqamw539c2rlsrjgmqvl-meson-1.4.2/bin:/nix/store/al76pgxn6m2i7p5yc9nih5zaajcil7ak-ninja-1.11.1/bin:/nix/store/n30sgrhf1qci199jwixmv580i0bqz33q-pkg-config-wrapper-0.29.2/bin:/nix/store/c0x5axsm1lz5w89n81xfqqx83l0x4jjj-jq-1.7.1-bin/bin:/nix/store/6kbwys80i23vxalfrij9z0vdkbabvz8p-git-2.44.1/bin:/nix/store/crvvgxgzxw4pmh9jnc605gygg8zyxq67-mercurial-6.6.3/bin:/nix/store/5w07wfs288qpmnvjywk24f3ak5k1np7r-python3-3.11.9/bin:/nix/store/p66hqwsh90q1xdb6ss31105rr11s4z9v-busybox-static-x86_64-unknown-linux-musl-1.36.1/bin:/nix/store/2wvb4326f069mz8zan43yx6nak6lsjqk-util-linux-2.39.4-bin/bin:/nix/store/i9pskh64xj3z9g64vr0aa79lis66f1dw-nix-2.26.0pre20241123_7fe80d1/bin:/nix/store/9khbrcmj8c92k19mx6wyiccimccs83hq-patchelf-0.15.0/bin:/nix/store/q6afjcz9h6ybcrai8w4z4k6ld7yqi9nd-gcc-wrapper-13.2.0/bin:/nix/store/fg7ass3a5m5pgl26qzfdniicbwbgzccy-gcc-13.2.0/bin:/nix/store/lhns6bwqlwfs4z6hd8jf08v4di08qqdy-glibc-2.39-52-bin/bin:/nix/store/xfm4mg874w5n39zbqx24yiw7hmka94n7-coreutils-9.5/bin:/nix/store/xcind1c9z66qg6g8xvj8ckz8dnp6r80q-binutils-wrapper-2.41/bin:/nix/store/jlw40q2bndc4db7iqzn6r2sz2r7kj4h4-binutils-2.41/bin:/nix/store/xfm4mg874w5n39zbqx24yiw7hmka94n7-coreutils-9.5/bin:/nix/store/v8sjbyscx6r58xngbhf0rsdf5czfyf8q-findutils-4.9.0/bin:/nix/store/m2mk5ch51868apcwgrx1vp22ydagnws9-diffutils-3.10/bin:/nix/store/h2gq8hngnsnwphzpq7992cip77lwrphm-gnused-4.9/bin:/nix/store/8p75w2cs6lgzakvz6q9xns7j876d0i8m-gnugrep-3.11/bin:/nix/store/ddkcg6irdsn0w2q05gphaaw3cblkml69-gawk-5.2.2/bin:/nix/store/dfbal2pwsci0nicaa6dsmm7sa3pld9kw-gnutar-1.35/bin:/nix/store/hx2j8xxxj6b007075jri865r4hcgyv9n-gzip-1.13/bin:/nix/store/bxmymv6ygxwrq0qlz6z2cwd8q9m56c5n-bzip2-1.0.8-bin/bin:/nix/store/60svfnl986z2819zqr2p01yc751n8hq0-gnumake-4.4.1/bin:/nix/store/wckka8fxv4h5hp74cbkhaw3fw7kbvcs1-bash-5.2p26/bin:/nix/store/4fgaxn11sfvv8gfcp1vxhslx470r68xw-patch-2.7.6/bin:/nix/store/lq3ggd6mcgxwzdk1rbkxwrj1pndda4yr-xz-5.4.7-bin/bin:/nix/store/2nrsjg5fg3n2i5hjlhmrq0iv6vvil0p0-file-5.45/bin
nix-tests> ++(/build/source/tests/functional/common/functions.sh:76) nix --extra-experimental-features nix-command daemon
nix-tests> warning: you don't have Internet access; disabling some network-dependent features
nix-tests> ++(/build/source/tests/functional/common/functions.sh:79) (( i++ ))
nix-tests> ++(/build/source/tests/functional/common/functions.sh:79) (( i < 300 ))
nix-tests> ++(/build/source/tests/functional/common/functions.sh:80) [[ -S /build/nix-test/main/compression-levels/dSocket ]]
nix-tests> ++(/build/source/tests/functional/common/functions.sh:81) DAEMON_STARTED=1
nix-tests> ++(/build/source/tests/functional/common/functions.sh:82) break
nix-tests> ++(/build/source/tests/functional/common/functions.sh:86) [[ -z x ]]
nix-tests> ++(/build/source/tests/functional/common/functions.sh:89) trap killDaemon EXIT
nix-tests> ++(/build/source/tests/functional/common/functions.sh:91) NIX_REMOTE_OLD=
nix-tests> ++(/build/source/tests/functional/common/functions.sh:92) export NIX_REMOTE=daemon
nix-tests> ++(/build/source/tests/functional/common/functions.sh:92) NIX_REMOTE=daemon
nix-tests> +(compression-levels.sh:5) clearStoreIfPossible
nix-tests> +(/build/source/tests/functional/common/functions.sh:33) isTestOnNixOS
nix-tests> +(/build/source/tests/functional/common/functions.sh:10) [[ '' == 1 ]]
nix-tests> +(/build/source/tests/functional/common/functions.sh:36) doClearStore
nix-tests> +(/build/source/tests/functional/common/functions.sh:48) echo 'clearing store...'
nix-tests> +(/build/source/tests/functional/common/functions.sh:49) chmod -R +w /build/nix-test/main/compression-levels/store
nix-tests> +(/build/source/tests/functional/common/functions.sh:50) rm -rf /build/nix-test/main/compression-levels/store
nix-tests> +(/build/source/tests/functional/common/functions.sh:51) mkdir /build/nix-test/main/compression-levels/store
nix-tests> +(/build/source/tests/functional/common/functions.sh:52) rm -rf /build/nix-test/main/compression-levels/var/nix
nix-tests> +(/build/source/tests/functional/common/functions.sh:53) mkdir /build/nix-test/main/compression-levels/var/nix
nix-tests> +(/build/source/tests/functional/common/functions.sh:54) clearProfiles
nix-tests> +(/build/source/tests/functional/common/functions.sh:25) profiles=/build/nix-test/main/compression-levels/test-home/.local/state/nix/profiles
nix-tests> +(/build/source/tests/functional/common/functions.sh:26) rm -rf /build/nix-test/main/compression-levels/test-home/.local/state/nix/profiles
nix-tests> +(compression-levels.sh:6) clearCache
nix-tests> +(/build/source/tests/functional/common/functions.sh:58) rm -rf /build/nix-test/main/compression-levels/binary-cache
nix-tests> ++(compression-levels.sh:8) nix-build dependencies.nix --no-out-link
nix-tests> accepted connection from pid 11783, user nixbld (trusted)
nix-tests> these 6 derivations will be built:
nix-tests>   /build/nix-test/main/compression-levels/store/mwvz7yzhq4ly19z13cjh4nygpm1h0f4w-unusual-logging.drv
nix-tests>   /build/nix-test/main/compression-levels/store/qykkqlkf179hg8b1lxx008xb9acn47xg-dependencies-input-0.drv
nix-tests>   /build/nix-test/main/compression-levels/store/mynkisz7ssbmjzpabb1ajxbq01bnsq4k-dependencies-input-2.drv
nix-tests>   /build/nix-test/main/compression-levels/store/r954bqgr8rjph74mrkh8m293hpay0x9n-fod-input.drv
nix-tests>   /build/nix-test/main/compression-levels/store/y734iiy2sawl189day13b8l1v713sf2c-dependencies-input-1.drv
nix-tests>   /build/nix-test/main/compression-levels/store/frlg94jswjg87gwbx8xdp8vff4cyb2jd-dependencies-top.drv
nix-tests> building '/build/nix-test/main/compression-levels/store/qykkqlkf179hg8b1lxx008xb9acn47xg-dependencies-input-0.drv'...
nix-tests> building '/build/nix-test/main/compression-levels/store/y734iiy2sawl189day13b8l1v713sf2c-dependencies-input-1.drv'...
nix-tests> building '/build/nix-test/main/compression-levels/store/mynkisz7ssbmjzpabb1ajxbq01bnsq4k-dependencies-input-2.drv'...
nix-tests> building '/build/nix-test/main/compression-levels/store/r954bqgr8rjph74mrkh8m293hpay0x9n-fod-input.drv'...
nix-tests> building '/build/nix-test/main/compression-levels/store/mwvz7yzhq4ly19z13cjh4nygpm1h0f4w-unusual-logging.drv'...
nix-tests> error: [json.exception.type_error.305] cannot use operator[] with a string argument with number
nix-tests> +(compression-levels.sh:8) outPath=
nix-tests> ++(compression-levels.sh:8) onError
nix-tests> ++(/build/source/tests/functional/common/functions.sh:237) set +x
nix-tests> compression-levels.sh: test failed at:
nix-tests>   main in compression-levels.sh:8

@Ericson2314
Copy link
Member

I think Robert already cherry picked this

@Ericson2314
Copy link
Member

#11921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants