Fix some BSD builds missing pthread functions#11156
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Jul 22, 2024
Merged
Fix some BSD builds missing pthread functions#11156Ericson2314 merged 2 commits intoNixOS:masterfrom
Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
eli-schwartz
suggested changes
Jul 22, 2024
In addition to adding the missing thread deps in the last commit, we also appear to need to skip `-Wl,--as-needed` flags that Meson wants to use, but doesn't work with our *BSD toolchains. See mesonbuild/meson#3593
Ericson2314
force-pushed
the
fix-bsd-pthread
branch
from
c9cc809 to
d39bbca
Compare
Member
|
@Ericson2314 There still appears to be a pthread-related issue on FreeBSD: https://hydra.nixos.org/build/267279816 Note that the need for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In addition to adding the missing thread deps in the last commit, we also appear to need to skip
-Wl,--as-neededflags that Meson wants to use, but doesn't work with our *BSD toolchains.Also, add missing thread deps.
Context
See mesonbuild/meson#3593
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.